search

ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

Added mpi env and enabled mpich ci tests #85

Closed zekemorton closed 2 years ago

zekemorton commented 2 years ago

This pull request added a new ENV to all base Dockerfiles to represent the flavor of MPI being installed instead of just an ARG. Using this mpi env, it can now distinguish between openmpi and mpich for the swift-t sanity checks. This allows for the mpich tests to be enabled in the ci checks.

Enabling the CI checks with mpich revealed a build failure with the combination of ubuntu, conda, and mpich when building swift-t. The build failure was remedied by also installing dpkg-dev when installing mpich

Addresses issues #79 and #64

zekemorton commented 2 years ago

All looks good, just small thing to add: for deployment need to specify MPI value here (openmpi?), since the image with tag latest could be only one (per sdk and per sdk-base)

Good catch! I must've missed that. I went ahead and made changes to use only openmpi