search

ExaWorks / psij-testing-service

0 stars 0 forks source link

Pa table header refresh #24

Open aschwanden1 opened 2 years ago

aschwanden1 commented 2 years ago

Hi everyone. I created several new directories (js, css, img, img_logos) and updated the references to all the stuff in those directories. Also, I've restyled the header and updated the look and feel of the tabs and overall site. Also, I've added a localstorage persistance layer which will be very easy to use. I've also implemented a new Vue Component called IntroBlurb. The idea that these blurbs would only be shown to the user until he/she decides to close them. Also, I've added configuration file, as we discussed, such that all the text strings will be configurable. So, if you don't like the intro blurbs or the Dashboard name, we can change them in the config file.

hategan commented 2 years ago

I think this is a great start.

We might want to split this into multiple PRs. In principle, each PR should fix one problem or add one new feature.

There are two reasons for this. One is that large PRs are hard to review. The second is that it is hard to reach consensus when there are many unrelated things to consider. For example, having assets split into subdirectories is something that is fairly straightforward and could go straight in. Other things, such as theming, have historically required lots of discussion, and, in this case we'd want to get closer to the theme on the exaworks.org web site, so that part is not as ready to go in.

aschwanden1 commented 2 years ago

Hi Mihael,

could we hold off on the exaworks themeing project for now? since that is a lower priority.

I can make smaller pull requests in the future, as you suggested.

aschwanden1 commented 2 years ago

Hi Mihael,

I have an idea. Maybe we could just consider the styling changes provisional for now? Dan Laney and I are working towards a Sept 30th deadline. We want to be able to wow the potential new users.

Then, later on when we do the exascale reskin, I can meet up with you online to discuss the color scheme. that way you can approve it before I implement the reskin.

sound okay?

hategan commented 2 years ago

I have an idea. Maybe we could just consider the styling changes provisional for now?

I see no reason to commit something that we plan not to use.

hategan commented 2 years ago

I can make smaller pull requests in the future, as you suggested.

Are you planning to split this PR or would you like me to review it as is?

aschwanden1 commented 2 years ago

Please review as is. Thank you.