search

Exafunction / codeium.nvim

A native neovim extension for Codeium
MIT License
644 stars 50 forks source link

Replace `buildVimPluginFrom2Nix` with `buildVimPlugin` #125

Closed pupbrained closed 6 months ago

pupbrained commented 6 months ago

buildVimPlugin2Nix is deprecated; buildVimPlugin takes in the same arguments and outputs the same things, so only a quick line change is needed.

pqn commented 6 months ago

Thanks for the PR. I don't know much about Nix, so maybe you can clear up some confusion I have.

  1. I see here that the build phase is now skipped: https://github.com/NixOS/nixpkgs/commit/0ab2c9642991c787c38cc131e7c5c935bff9cd88 But seems like we use the build phase?
  2. The commit I linked is 23.11, whereas we are on 22.11?
pupbrained commented 6 months ago

Thanks for the PR. I don't know much about Nix, so maybe you can clear up some confusion I have.

  1. I see here that the build phase is now skipped: NixOS/nixpkgs@0ab2c96 But seems like we use the build phase?
  2. The commit I linked is 23.11, whereas we are on 22.11?

  1. I'm not sure about the build phase thing, but I've tested with buildVimPlugin and it worked just like it does with buildVimPluginFrom2Nix.

  2. From what I've seen, most people use inputs.nixpkgs.follows to force the flake to use their own version of nixpkgs. We could switch the flake to use nixpkgs 23.11, since that's the latest stable version.