search

Exafunction / codeium.nvim

A native neovim extension for Codeium
MIT License
647 stars 50 forks source link

Update auth-menu.lua #64

Closed rgzntrade closed 1 year ago

rgzntrade commented 1 year ago

it should be vim.ui.input

WillEhrendreich commented 1 year ago

@PreetamSing that's not gonna work.

as of NVIM v0.10.0-dev-422+g68e2d7229 , it's not integrated or something. point of the matter is this is a breaking change, and I've had to do what the pr here did to get it working. https://github.com/neovim/neovim/pull/19413

rgzntrade commented 1 year ago

You are right, but with the stable version（0.9.1）, inputsecert does not work yet. Please consider compatibility

PreetamSing commented 1 year ago

@WillEhrendreich @rgzntrade I'm able to use inputsecret function in NVIM v0.8.3 as well as in NVIM v0.9.1.

Maybe you're trying to use that function from vim.ui module. Try accessing it from vim.fn path, as written in my initial suggestion code. Or you can also run :help inputsecret command for more info.

Let me know if I'm misunderstanding something.

WillEhrendreich commented 1 year ago

ah, ok. yep. you're right @PreetamSing, the fn vs ui thing was getting in the way. works great on my end with what's in the pr. thanks!

aerosol commented 1 year ago

(edited) rgzntrade:main works for me with neovim 0.9.1 - could not get the token prompt when on main. Thanks!

WillEhrendreich commented 1 year ago

I take it back, that code does not work, I had to go back to vim.ui.input, because it doesn't save the auth for some reason otherwise

rgzntrade commented 1 year ago

[C]: in function 'inputsecret' ...vim_up/lazy/codeium.nvim/lua/codeium/views/auth-menu.lua:5: in function 'get_key' ...vim_up/lazy/codeium.nvim/lua/codeium/views/auth-menu.lua:100: in function 'callback' ...vim_up/lazy/codeium.nvim/lua/codeium/views/auth-menu.lua:122: in function 'on_choice' .../nvim_up/lazy/dressing.nvim/lua/dressing/select/init.lua:78: in function '' vim/_editor.lua: in function <vim/_editor.lua:0>

This will create a new error