Exafunction / codeium.vim

Free, ultrafast Copilot alternative for Vim and Neovim
https://codeium.com
MIT License
3.68k stars 124 forks source link

Remove <Right> key accept completion #387

Closed dror-g closed 6 days ago

dror-g commented 1 week ago

Emergency fix. Perhaps make optional, or only when completion available.

CLAassistant commented 1 week ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ltecheroffical commented 1 week ago

This is important, Without this fix, Codeium broke my right arrow key in insert mode

dror-g commented 1 week ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

yea don't hold your breath.. license seems fine but I don't see the need to sign anything for a "drive-by PR". Feel free to fix in your own PR. Will leave this open as reminder, close at your convenience. cheers.

LeonardoMor commented 1 week ago

This is important, Without this fix, Codeium broke my right arrow key in insert mode

You can disable the default bindings with:

let g:codeium_disable_bindings = 1

or in Neovim:

vim.g.codeium_disable_bindings = 1
ltecheroffical commented 1 week ago

This is important, Without this fix, Codeium broke my right arrow key in insert mode

You can disable the default bindings with:

let g:codeium_disable_bindings = 1

or in Neovim:

vim.g.codeium_disable_bindings = 1

I had to apply a hacky fix for this due to the fact that the arrow key binding is registered too early

LeonardoMor commented 1 week ago

Yes. Right proved to be a far too common key to map in insert mode. It'll not be mapped by default anymore once #398 gets merged.

dror-g commented 6 days ago

Yes. Right proved to be a far too common key to map in insert mode. It'll not be mapped by default anymore once #398 gets merged.

Resolved. Thank you!