Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

Disable ABL wall function for a zhi BC #1027

Closed marchdf closed 2 months ago

marchdf commented 2 months ago

Summary

Disable the Moeng wall model on zhi.

Pull request type

Please check the type of change your PR introduces:

Checklist

gpu_tests.txt cpu_tests.txt

Additional background

Closes #803

moprak-nrel commented 2 months ago

We may need to disable this for more than just the moeng shear stress, anything that uses quantities from MOData will be incorrect at zhi since it will be using the quantities computed at zlo like: utau, wspd_mean, etc. I suspect the right fix might be to disable wall models for zhi entirely in ABLWallFunction. Example in the Schumann wall model: https://github.com/Exawind/amr-wind/blob/38dfd817bace4e6d864d9c0b97ab01e9ff2b7e47/amr-wind/wind_energy/ShearStress.H#L92-L103