Add sampling of derived fields - Githubissues

Exawind / amr-wind

AMReX-based structured wind solver

https://exawind.github.io/amr-wind

Other

103 stars 78 forks source link

Add sampling of derived fields #1030

Closed marchdf closed 1 month ago

marchdf commented 2 months ago

Summary

Add ability to sample derived fields

Pull request type

Please check the type of change introduced:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Checklist

The following is included:

[x] new unit-test(s)
[x] new regression test(s)
[x] documentation for new capability

This PR was tested by running:

the unit tests
- [x] on GPU
- [x] on CPU
the regression tests
- [x] on GPU
- [x] on CPU

gpu_tests.txt cpu_tests.txt

Additional background

Closes: #999

marchdf commented 2 months ago

This triggered something I didn't foresee... the derived fields typically don't have grow cells. Which means that sampling (i.e. interpolation of a field to a particle) can reach beyond the box bounds and cause an OOB on the derived field. Going to have to fix this before this can go through.