Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

give actuator src a ghost cell and populate it (interior) #1036

Closed mbkuhn closed 1 month ago

mbkuhn commented 2 months ago

Summary

Currently, sampling the actuator src term is erroneous because it does not have any ghost cells. This PR gives the actuator src term a ghost cell and populates it in interior boundaries to ensure that it can be sampled properly.

Pull request type

Checklist

The following is included:

This PR was tested by running:

Additional background

I think that this is related to the changes in #1030, but I don't think it's redundant.

mbkuhn commented 2 months ago

Videos from sampled actuator src without the changes in this PR (errors due to referencing ghost indices that do not exist, leading to accessing values from another part of the array) :

https://github.com/Exawind/amr-wind/assets/31661049/072d078a-f992-46b9-87ac-158cc38fa8f1

https://github.com/Exawind/amr-wind/assets/31661049/3dd25e6c-4f6e-4996-8c84-bd39b906123d

mbkuhn commented 2 months ago

Screenshot with the changes from this PR:

Screenshot 2024-05-01 at 3 05 34 PM