Get number of points along the blade

Exawind / amr-wind

AMReX-based structured wind solver

https://exawind.github.io/amr-wind

Other

103 stars 78 forks source link

Get number of points along the blade #1039

Closed tonyinme closed 1 month ago

tonyinme commented 2 months ago

Summary

Pull request type

Please check the type of change introduced:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Checklist

The following is included:

[ ] new unit-test(s)
[ ] new regression test(s)
[ ] documentation for new capability

This PR was tested by running:

the unit tests
- [ ] on GPU
- [ ] on CPU
the regression tests
- [ ] on GPU
- [ ] on CPU

Additional background

This was a former bugfix that was reintroduced. This is a re-implementation of the bug fix.

Issue

marchdf commented 1 month ago

There is actually another bug here. I am moving these fixes to another PR and adding the other fix I found. This will be in : https://github.com/Exawind/amr-wind/pull/1043

marchdf commented 1 month ago

@tonyinme can you check to make sure I moved the fixes right? It will be #1043 and it will be in amr-wind/wind_energy/actuator/turbine/fast/turbine_fast_ops.H. You can also see what I mean by using .begin() to get around that type error you were seeing. And the bugfix I was talking about was the MPI broadcast had the wrong size for sz_info.

tonyinme commented 1 month ago

@tonyinme can you check to make sure I moved the fixes right? It will be #1043 and it will be in amr-wind/wind_energy/actuator/turbine/fast/turbine_fast_ops.H. You can also see what I mean by using .begin() to get around that type error you were seeing. And the bugfix I was talking about was the MPI broadcast had the wrong size for sz_info.

Yes, I went over it and the implementation looks good.