Tensor ops unit tests - Githubissues

Exawind / amr-wind

AMReX-based structured wind solver

https://exawind.github.io/amr-wind

Other

105 stars 83 forks source link

Tensor ops unit tests #1046

Closed marchdf closed 4 months ago

marchdf commented 4 months ago

Summary

Increase test coverage to the tensor ops.

Pull request type

Please check the type of change introduced:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[x] Other (please describe): test coverage increase

Checklist

The following is included:

[x] new unit-test(s)
[ ] new regression test(s)
[ ] documentation for new capability

This PR was tested by running:

the unit tests
- [x] on GPU
- [x] on CPU
the regression tests
- [ ] on GPU
- [ ] on CPU

Additional background

Issue Number:

moprak-nrel commented 4 months ago

This is only tangential to the PR, but looking at the vector ops it has both vec_norm and vec_mag. From the typical definition of norm, should it not be the same for L2? The general norm would be (sum(x_i^p))^(1/p)