Remove duplicates from IO - Githubissues

Exawind / amr-wind

AMReX-based structured wind solver

https://exawind.github.io/amr-wind

Other

105 stars 83 forks source link

Remove duplicates from IO #1053

Closed marchdf closed 4 months ago

marchdf commented 4 months ago

Summary

If using derived fields it is possible to end up with a bunch of duplicate fields in the output. This attempts to fix that.

Pull request type

Please check the type of change introduced:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Checklist

The existing abl_sampling regression test had duplicate fields, now it doesnt. So we can consider that the reg test.

This PR was tested by running:

the unit tests
- [ ] on GPU
- [ ] on CPU
the regression tests
- [ ] on GPU
- [ ] on CPU

marchdf commented 4 months ago

@mbkuhn can you check that this solves the netcdf problem you were seeing?