search

Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

Readd waves2amr #1055

Closed marchdf closed 1 month ago

marchdf commented 1 month ago

Summary

I was having all sorts of errors on a machine with an existing clone amr-wind. "fatal: not git repository", "unable to fetch Waves2AMR". This got me through all those errors. I am not sure what's up. Maybe the trailing slash? Another point... we should move this submodule repo out of a private GH account and into something official. We can move it Exawind org if need be. Or if it will only be used by amr-wind, I would prefer not having a submodule and just making it part of the source.

Pull request type

Please check the type of change introduced:

mbkuhn commented 1 month ago

Didn't expect all of these issues! As its own repo, I thought it might be useful for ERF as well, for an evolving lower boundary. I will look into both of your suggestions. By the way, do the changes in this PR fix the errors you were getting?

marchdf commented 1 month ago

This PR fixes the issues I was getting and make it look like the other submods.