Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

deprecating old HOS waves implementation #1059

Closed mbkuhn closed 1 month ago

mbkuhn commented 1 month ago

Summary

With the advent of Waves2AMR, the old way of importing HOS data is no longer needed. Also, it was a very manual non-documented approach that is not desirable in the long-term

Pull request type

Checklist

The following is included:

This PR was tested by running:

marchdf commented 1 month ago

This is my favorite kind of PR. I think you take the win on most LOCs removed in amr-wind.

mbkuhn commented 1 month ago

This is my favorite kind of PR. I think you take the win on most LOCs removed in amr-wind.

It's kind of cheating because they're lines of data, and I was the one who added them, but I'll take the win.