Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

Remove ChannelFlow.density and replace with just incflo.density #1078

Closed moprak-nrel closed 1 month ago

moprak-nrel commented 1 month ago

Summary

ChannelFlow seems to define it's own density, and it is unclear why this needs to be a separate parameter from incflo.density. This PR consolidates those.

Pull request type

Please check the type of change introduced:

The following is included:

This PR was tested by running:

Additional background

Issue Number:

moprak-nrel commented 1 month ago

This PR also fixes a potential bug with the wall function, previously this assumed that density is 1.0, and set nu = mu instead of nu = mu/rho.