Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

Fix non-deterministic MMC bug on GPU #1085

Closed moprak-nrel closed 1 month ago

moprak-nrel commented 1 month ago

Summary

Initialize m_abl_tendency to false, it is currently just set with a pp.query. This leads to a buggy non-deterministic behavior when it is not explicitly set in the input file. This should hopefully fix #1057.

Pull request type

Please check the type of change introduced:

Checklist

The following is included:

This PR was tested by running:

Additional background

Issue Number: #1057

moprak-nrel commented 1 month ago

The offending call is at https://github.com/Exawind/amr-wind/blob/277e7d61e37a7a3c10f6b26b8f9c71832f68dc83/amr-wind/wind_energy/ABLMesoscaleInput.cpp#L67-L68