Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
103 stars 78 forks source link

Another way to fix the UDF MAC fills #1092

Closed marchdf closed 3 weeks ago

marchdf commented 4 weeks ago

Summary

The dirichlet fill now depends on if we are filling a face-centered or node centered field.

Pull request type

Please check the type of change introduced:

Checklist

This PR was tested by running:

Issue Number: #1076

marchdf commented 4 weeks ago

Still need to do it for lev != 0

marchdf commented 3 weeks ago

This PR has made a lot of people very angry and been widely regarded as a bad move.

(the real reason for closing: templating wont work because for lev != 0 we need to pass in an Array of bc functs and so they need to have the same type. It was fun while it lasted. #1093 should be a better fix)