search

Exawind / amr-wind

AMReX-based structured wind solver
https://exawind.github.io/amr-wind
Other
106 stars 83 forks source link

Enable multilevel inflow/outflow BC with native format #970

Closed marchdf closed 7 months ago

marchdf commented 7 months ago

This was already done for netcdf, now doing it for the native format.

marchdf commented 7 months ago

Results of CPU test. The only test failing is hbl_godunov and it is failing because of something changed in #965. @mbkuhn is checking to see that that is ok.

mbkuhn commented 7 months ago

Were you able to confirm that it's "working"? The reg test is fine going forward, but because there's no unit test, have you checked that it's actually writing and reading the additional level?

marchdf commented 7 months ago

Yup it's all working. The reg tests basically test that and it works. A long time ago we talked about unit tests but ultimately gave up on the idea. It's a weird capability because it interacts with the filesystem so much and require basically a fully functional sim that the "best" way to test was the reg tests with test dependencies.

Results of GPU tests

mbkuhn commented 7 months ago

Yep, sounds great! Thanks for filling me in.

ewquon commented 7 months ago

Fantastic! Thanks for putting this in, @marchdf. We were just talking a couple days ago about how this is critically needed for another project.