search

Exawind / nalu-wind

Solver for wind farm simulations targeting exascale computational platforms
https://exawind.github.io/nalu-wind/
Other
124 stars 85 forks source link

Balanced buoyancy #1280

Closed wjhorne closed 3 months ago

wjhorne commented 3 months ago

@mbkuhn These are the balanced buoyancy changes. I still need to evaluate more solid body cases to ensure that it has fixed everything we saw, but so far it has been good in my testing.

mbkuhn commented 3 months ago

@wjhorne I got it to pass CI, but we should still make sure that the reg tests pass properly and also should turn on the new feature in one of the reg tests, probably VOFDroplet

mbkuhn commented 3 months ago

Reg tests look good. I added the balanced buoyancy option to the VOFDroplet reg test and confirmed that it gets a different result. I will check this with the hybrid cases, and it should be good to go, though we did want another nalu-wind developer to sign off on it as well.

wjhorne commented 3 months ago

@mbkuhn I will discuss this a bit further, but I introduced a new weighting that should give you much more improvement. Feel free to give it a run if you would like to see the difference. I will also introduce a mask later today that will remove the fixed wall issue I noted yesterday.

wjhorne commented 3 months ago

@psakievich Do you know anyone that could review this to get it in? Our testing looks good for it