search

Exawind / nalu-wind

Solver for wind farm simulations targeting exascale computational platforms
https://nalu-wind.readthedocs.io
Other
123 stars 83 forks source link

Many of Nalu-Wind reg tests are not actively being run #1289

Open mbkuhn opened 2 weeks ago

mbkuhn commented 2 weeks ago

The dashboard (and general usage of Nalu-Wind) uses hypre solvers instead of trilinos solvers. However, the majority of the Nalu-Wind reg tests still employ trilinos solvers, and these are not being run during the nightly tests.

Let's make an effort to convert these tests to using hypre and thus include them. After converting the trilinos-based input arguments to use hypre, these cases should be checked by either comparing the norms and ensuring that the diffs are reasonably small or by looking at the actual flow physics to ensure things are running properly. Something to be aware of: not all source terms are hypre-compatible, so some coding may be needed to add updated kernels, like in this merged PR: https://github.com/Exawind/nalu-wind/pull/1274

Below are all the reg tests with tpetra included (grep -linr -m 1 "tpetra" reg_tests/test_files/*, then the ones with "Trilinos" in the test name removed):

BumseokLee commented 1 week ago

Hi

I found that two test cases below employ the strong symmetry boundary condition.

However, hypre doesn't currently support the strong symmetry boundary conditions.

Probably, I will open a new issue for this.

mbkuhn commented 4 days ago

I will take these:

mbkuhn commented 4 days ago

@itopcuoglu, could you take these on?

I'm sticking to ones that say "decoupled_overset_solve: yes" because I'm not sure if the tightly coupled overset pressure solves are compatible with hypre.

mbkuhn commented 4 days ago

@sseraj, could you try converting this case to use hypre?

mbkuhn commented 4 days ago

I'm going to remove from the list all of the ones with "Trilinos" in the name because I think those are intended for testing trilinos solvers.

BumseokLee commented 4 days ago

@mbkuhn I think we can delete the BLTFlatPlateT3A case. This case was created for the transition model two years ago. However, the transition model wasn't merged at that time, and for this reason, Jon turned off the case in CTestList.cmake. It has never been used since then. Currently, I am creating a new reg. test for the transition model using an existing airfoil mesh in the repository.