Fix for debug build: Fix ill-formed KOKKOS macro function decoration.

Exawind / nalu-wind

Solver for wind farm simulations targeting exascale computational platforms

https://exawind.github.io/nalu-wind/

Other

124 stars 85 forks source link

Fix for debug build: Fix ill-formed KOKKOS macro function decoration. #1317

Closed overfelt closed 1 month ago

marchdf commented 1 month ago

Closes #1302

jrood-nrel commented 1 month ago

This is great. Thanks James.

marchdf commented 1 month ago

@overfelt thank you for taking care of this! I would not have gotten there. My GPU dev box is down this week so hopefully I can test it next week.

overfelt commented 1 month ago

It is crazy that on a debug build the function became a no-op. No warning, no error. It just did nothing. Stared at the code for quite a while before it jumped out at me the "KOKKOS_FUNCTION KOKKOS_FUNCTION" in the declaration.

marchdf commented 1 month ago

eagle eyes. Thank you very much!