Exceen / 4chan-downloader

Python3 script to continuously download all images/webms of multiple 4chan thread simultaneously - without installation
MIT License
277 stars 36 forks source link

Add download path argument to allow custom download path #17

Closed rkcf closed 3 years ago

rkcf commented 5 years ago
rkcf commented 5 years ago

@Exceen. Yeah i had thought about that. I guess the question is wether the custom path specified should point to the directory where a downloads dir will be created, or a directory where the actual downloaded files should be put. I was leaning more on the second. But it would have to mess with the new directory creation.

Is the new directory really needed? Maybe the creation of that separate directory could be done with a passed flag? But that would require more rewriting.

Maybe instead of having a new dir created, have the script automatically not re-download deleted images, unless explicitly told to with a flag.

Exceen commented 4 years ago

The new directory isn't really needed, it was just the way i wrote this script originally. The downloads directory keeps track of all downloaded images and the new folder just saves the new files. This way you can delete images you don't want from the new directory and the script won't download them again. After the thread is dead, you just delete the thread-directory from the downloads directory and then you have a thread-directory inside the new directory with just those images you want to save.

Actually the usage of the downloads directory should be rewritten as it is only used to somewhat remember which files have already been downloaded and which not. This could ofc be done with just a single file.