ExceptedPrism3 / Logger

Log all Activities from Players or Server Side!
https://www.spigotmc.org/resources/logger.94236/
GNU Affero General Public License v3.0
40 stars 18 forks source link

Shaded dependencies are not relocated #24

Closed A248 closed 2 years ago

A248 commented 2 years ago

Describe the bug Shaded dependencies in Logger-Velocity are not relocated. Any dependencies you shade need to be relocated to your own namespace to avoid conflicts with other plugins.

In particular, this causes a conflict with LibertyBans, another Velocity plugin. LibertyBans detected the bug automatically, and a LibertyBans user reported the problem accordingly: https://github.com/A248/LibertyBans/issues/165

To Reproduce Steps to reproduce the behavior:

  1. Install Logger-Velocity
  2. Install LibertyBans
  3. View report generated by LibertyBans' automated detection of this bug

Expected behavior Logger-Velocity properly relocates its dependencies to its own namespace.

Screenshots image

Server & Version (please complete the following information):

zRxnx commented 2 years ago

Hello :) I reported the thing on LibertyBan's repositorie and i found more warns, maybe this is the same but i want to be sure

Have a nice day! image

thelooter commented 2 years ago

Which branch of Logger are you using?

thelooter commented 2 years ago

The Postgres Branch is the only branch containing the Postgres Dependency. The Branch is not in a working State currently.

A248 commented 2 years ago

@zRxnx was probably using the Postgres branch. In any case, there are unrelocated dependencies on both the Improving and PostgreSQL branches. I've made a PR for the Improving branch.