Fishing with Croptopia installed always yields two items instead of one

ExcessiveAmountsOfZombies / Croptopia

Fabric and Forge mod that adds crops and food to the game.

https://www.curseforge.com/minecraft/mc-mods/croptopia-fabric

MIT License

85 stars 70 forks source link

Fishing with Croptopia installed always yields two items instead of one #602

Open herebecush opened 4 months ago

herebecush commented 4 months ago

Make sure you are not opening a duplicate.

[X] I have searched the issue tracker and did not find an issue describing my bug.

Platform.

Fabric

Minecraft version.

1.20.4

Croptopia version.

3.0.1

What happened?

Every time that someone fishes on our server with Croptopia installed (tested with nothing else except Croptopia + EpheroLib), they always receive two items instead of one. It seems like somewhere inside the mod perhaps some sort of "give item" command is giving them a Croptopia item on top of the vanilla item rather than, as intended, instead of the vanilla item.

Relevant log.

No response

Additional information.

No response

herebecush commented 4 months ago

Having looked into the source code the only part I can see potentially impacting this is in /fabric/src/main/java/com/epherical/croptopiaitems/CropLootTableModifier.java around lines 36 - 48... perhaps this is adding a second loot table lookup to take items from rather than amending the existing loot table and then Minecraft is selecting one from each rather than selecting one from either.

herebecush commented 4 months ago

Additionally I have tried building the mod myself using ./gradlew :fabric:build as outlined in this repo's README file, but I receive this error:

herebecush commented 4 months ago

bump

Any idea of what can be done as a quick first step on either the fish issue or the gradle issue?

herebecush commented 3 months ago

@ExcessiveAmountsOfZombies Any assistance on this would be appreciated, even if it's just how to get the build working so I can modify the mod myself