search

ExchangeBC / devex

This was the original Mean app for the BC Developers' Exchange. It has been superseded by two products, github.com/bcgov/digital_marketplace and github.com/bcgov/bcdevexchange.
Apache License 2.0
26 stars 41 forks source link

Government User #5

Closed ccoldwell closed 7 years ago

ccoldwell commented 8 years ago

this is where we put all conversations regarding this work

melavo commented 8 years ago

Ok here is a list of task as defined by our conversation.

1) Sign up will lead to page that have 2 buttons. a) Government User Sign up b) non-Government User Sign Up 2) b will go to the current sign up form, a will go to form that ask for Organization Name. string 3) When sign up with gov. Role will be = "gov_request" 4) Add Manage Gov. Request in admin under manage user. 5) Manage government User will have a list of request. when click approve... change role to "gov". If not approve TBD. 6) add organization to the user view/edit module 7) check that if duplicate email then error message pop up 8) check that forgot password working 9) check if profile image works

ccoldwell commented 8 years ago

yes, with clarifications:

melavo commented 8 years ago

Gotcha

melavo commented 8 years ago

You found out what happen to user when gov user is rejected? Thanks

ccoldwell commented 8 years ago

Let's just remove the request role for now.

On Tue, Nov 8, 2016 at 9:36 AM, Wayne Vo notifications@github.com wrote:

You found out what happen to user when gov user is rejected? Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-259204447, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDEQn-5ybLcvTShD908YSqxx9JZeCks5q8LMCgaJpZM4Kpw4g .

melavo commented 8 years ago

Sorry what do you mean?

On Tue, Nov 8, 2016 at 11:02 AM, ccoldwell notifications@github.com wrote:

Let's just remove the request role for now.

On Tue, Nov 8, 2016 at 9:36 AM, Wayne Vo notifications@github.com wrote:

You found out what happen to user when gov user is rejected? Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5#issuecomment-259204447 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDEQn- 5ybLcvTShD908YSqxx9JZeCks5q8LMCgaJpZM4Kpw4g .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-259227691, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbQawFiwC7DsV4N0LTBLUAumaBM_ldoks5q8MdbgaJpZM4Kpw4g .

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

ccoldwell commented 8 years ago

when the user is rejected, just remove the -request role. We can figure out what to do from a business standpoint a little later. Eventually we would like to send them an email letting them know, but there is yet to exist a business process to send them through.

melavo commented 8 years ago

I push all my changes to the branch gov user. I am testing and will commit any other bugs for Monday, but everything should be ok. Fyi. when reject I made it user so it different from approve so we can test. Thanks

melavo commented 8 years ago

Let me know if you have any changes or if ok I can do a pull request. Thanks

ccoldwell commented 8 years ago

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!
ccoldwell commented 8 years ago

Also, make sure that you take care of all merge issues for the final pull request. Thanks. I will stay out of there.

melavo commented 8 years ago

I have to deal with a family emergency, will change tonight. I will do a pull request after these tweaks. thanks

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Also, make sure that you take care of all merge issues for the final pull request. Thanks. I will stay out of there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci6.googleusercontent.com/proxy/TVG2OKO9YLCzIgbMKLsCISj-dPAmsjjxJMyzIcTfL6rlNQ0B0sJt0vmYCyWcRemkqtfofZ9U4WpJZNh0o_cu69Hp54zNWn3sXAXfBiBqfmgVjhiu6Nnm8nN6JzHlDGVXyx1PEQNK1ZoQ0JpYmmsKwRLIjIHkIg=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQa8HKuPK5cSHY_UvO_aqFGVEKKqOwks5q-K1UgaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

melavo commented 8 years ago

Sorry, I don't understand what you mean by #2.

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNMrbBA6rtpXEcR9lxV3YiMMR_c-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl_FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiRujhtg_w=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi_3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

ccoldwell commented 8 years ago

Hi Wayne, I mean this:

when a new government user is created they will have two roles:

  • user
  • gov-request when they are accepted:
  • user
  • gov when they are rejected:
  • user

thats it.

Chris

On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo notifications@github.com wrote:

Sorry, I don't understand what you mean by #2.

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM rbBA6rtpXEcR9lxV3YiMMRc-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR ujhtgw=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi 3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-260458556, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g .

melavo commented 8 years ago

Right now role is stored as string, Do you want me to keep it as string or change it to array since we now have more then one role per user. Thanks

On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell notifications@github.com wrote:

Hi Wayne, I mean this:

when a new government user is created they will have two roles:

  • user
  • gov-request when they are accepted:
  • user
  • gov when they are rejected:
  • user

thats it.

Chris

On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo notifications@github.com wrote:

Sorry, I don't understand what you mean by #2.

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM rbBA6rtpXEcR9lxV3YiMMRc-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR ujhtgw=s0-d-e1-ft#https://github.com/notifications/beacon/AFbQawo9zzi 3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5#issuecomment-260458556 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_ sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-260716084, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88-Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g .

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

ccoldwell commented 8 years ago

the model shows that user.roles is an array of strings, so it already handles multiple

On Tue, Nov 15, 2016 at 10:40 AM, Wayne Vo notifications@github.com wrote:

Right now role is stored as string, Do you want me to keep it as string or change it to array since we now have more then one role per user. Thanks

On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell notifications@github.com wrote:

Hi Wayne, I mean this:

when a new government user is created they will have two roles:

  • user
  • gov-request when they are accepted:
  • user
  • gov when they are rejected:
  • user

thats it.

Chris

On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo notifications@github.com wrote:

Sorry, I don't understand what you mean by #2.

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci3.googleusercontent.com/proxy/JVFKOwcboNN7f2uGQHZmEOWjadAHNM rbBA6rtpXEcR9lxV3YiMMRc-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR ujhtgw=s0-d-e1-ft#https://github.com/notifications/ beacon/AFbQawo9zzi 3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5# issuecomment-260458556 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDGQUxOf7_paAn_ sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5#issuecomment-260716084 , or mute the thread https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88- Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g .

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-260728049, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDGGFywjtYaJXCMv_p5hfqN-WTAgBks5q-fytgaJpZM4Kpw4g .

melavo commented 7 years ago

Done and did a pull request. Thanks

On Tue, Nov 15, 2016 at 11:09 AM, ccoldwell notifications@github.com wrote:

the model shows that user.roles is an array of strings, so it already handles multiple

On Tue, Nov 15, 2016 at 10:40 AM, Wayne Vo notifications@github.com wrote:

Right now role is stored as string, Do you want me to keep it as string or change it to array since we now have more then one role per user. Thanks

On Tue, Nov 15, 2016 at 9:56 AM, ccoldwell notifications@github.com wrote:

Hi Wayne, I mean this:

when a new government user is created they will have two roles:

  • user
  • gov-request when they are accepted:
  • user
  • gov when they are rejected:
  • user

thats it.

Chris

On Mon, Nov 14, 2016 at 12:50 PM, Wayne Vo notifications@github.com wrote:

Sorry, I don't understand what you mean by #2.

On Monday, November 14, 2016, ccoldwell notifications@github.com wrote:

Hi @melavo, I went through and there were only two things that I made note of.

  1. Please move the organization field down below the email field on the form
  2. Always have the 'user' role present. So a request has both gov-request and user, then gov and user, or simply user if denied. Other than that things are looking great! Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci3.googleusercontent.com/proxy/ JVFKOwcboNN7f2uGQHZmEOWjadAHNM rbBA6rtpXEcR9lxV3YiMMRc-EYDv1rHxU62f4xaxxWOabPOV9HHeDv6p5fl FCM35stxOMJWxUEPG4xyOxpntRsiRQNmCMp4QMM5LpYUB6JfT4unO4H8iJiR ujhtgw=s0-d-e1-ft#https://github.com/notifications/ beacon/AFbQawo9zzi 3Dvkap6NP2VuFWZXJllMks5q-Kz7gaJpZM4Kpw4g.gif

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5# issuecomment-260458556 , or mute the thread https://github.com/notifications/unsubscribe- auth/AAEtDGQUxOf7_paAn_ sypzo9YuTkqNisks5q-MmngaJpZM4Kpw4g .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5# issuecomment-260716084 , or mute the thread https://github.com/notifications/unsubscribe-auth/AFbQa8j_2Hkej88- Iq7zGbvm1bcbDx0Yks5q-fJkgaJpZM4Kpw4g .

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/BCDevExchange/devex/issues/5#issuecomment-260728049 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAEtDGGFywjtYaJXCMv_ p5hfqN-WTAgBks5q-fytgaJpZM4Kpw4g .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BCDevExchange/devex/issues/5#issuecomment-260736269, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbQa1LX4n2v364ozEODyl6tR4c27Iz0ks5q-gOGgaJpZM4Kpw4g .

Wayne Vo MelaVo Media Ltd. Web Developer & Designer 778-230-3652

mark-a-wilson commented 7 years ago

Thanks @melavo for the great work! Closing this issue.