Open jschwartzenberg opened 5 years ago
Probably a lot of work is needed. Related information:
What are the chances that this add-on will be written to be compatible with Thunderbird v68? I believe it will to be out of beta soon.
Agreed! Would love to see this available on 68, i am no longer able to use this now that i have updated. bummer....
I will not update TB until I know if I can use this addon afterwards. Is there anything that can be done to help sorting this request out?
@elhennig As far as I can tell, there is a lot of work necessary. Most of the add-on code is of questionable quality and several years old. @Trim did a lot of structural clean-up work in the past but we didn't touch any of the Thunderbird specific add-on code.
I will try to take a closer look once Ubuntu has officially rolled out the update and I don't have to mess around with prerelease channels.
First thing I did was fresh install TB68 in a VM and see which extensions would actually work, and which ones wouldn't. This is the first "must have" extension I came across that is incompatible.
I'm in no rush - thanks for doing everything you do, advancingu. I'm fine with TB60 ESR at the moment. 68 can wait!
@advancingu @Trim I want to help facilitate updates for TB 68 ESR compatibility, per my multiple comments in #163. As I asked there, would it be possible for me to be added as member of ExchangeCalendar so I can contribute?
Edited to add: there is relevant discussion about add-on compatibility happening right now on tb-planning, which is an opportunity to have the ExchangeCalendar extension, which is critically important for many users, receive similar recognition and support to other critically important calendaring extensions.
@jamesquilty Thanks for your offer. Best way to start is simply by forking the repository and then submitting merge requests (PRs) from your repository back to this one here. This can be done independent of membership.
Regarding the mailing list, are you referring to this thread?
@advancingu There have been several relevant threads in tb-planning August, since the request to relay an offer of help with updating extensions I cited in #163 comment 5. I'd specifically draw your attention to this thread, and specifically the discussion from this post.
In those threads, there's a link to https://developer.thunderbird.net/add-ons/updates/tb68 which is directly relevant to this issue:
Changes in Thunderbird 61-68
This document tries to cover all the changes that may by needed to make add-ons compatible with Thunderbird 68. If you find stuff that is no longer working but is not yet on this list, ask for help and advice in the mozilla.dev.apps.thunderbird newsgroup or check our communication channels.
Hi guys,
I just updated my rather complex extension to work with TB 68 and, yes, it took some time to figure out everything but as of now the "old style" XUL interface can be kept. You need to convert from install.rdf to manifest.json and then (probably) fix the preferences a bit. The major changes for me were to replace the
I would be glad to help if you need some advice or suggestions.
Cheers, Holger
Workaround for Arch/Manjaro users so that they can stay at Thunderbird 60.x: I just added it (based on thunderbird-bin) due to this issue: https://aur.archlinux.org/packages/thunderbird-60-bin
Hi folks,
could anyone say (or write down) a few words about the problem(s) with the current extension and TB68? That would provide interested developers (like me) with a starting point for debugging or fixing issues.
Best, Florian
Hello the plugin info file format and name was changed,
the old one is install.rdf the new one is manifest.json
BR
I am running Fedora 29 and installed some updates which caused Thunderbird to get updated to 68.1.0 (package thunderbird-68.1.0-1.fc29.x86_64). Now my exchange calendar no longer works.
I tried to install exchangecalendar-v5.0.0-beta1.xpi but Thunderbird refused to install it saying "not compatible with Thunderbird 68.1.0).
Thanks for looking.
Alternative solution for TB 68 which does not require this add-on: use DavMail. It is a separate (java) application, which acts kind of a protocol translator between Outlook 365/Exchange and TB. Then you can set up your calendar using the CalDav protocol (no need to change your email settings).
Alternative solution for TB 68 which does not require this add-on: use DavMail. It is a separate (java) application, which acts kind of a protocol translator between Outlook 365/Exchange and TB. Then you can set up your calendar using the CalDav protocol (no need to change your email settings).
Also, for Linux, Evolution from the Gnome project, works well. Im not a fan because I like keeping my mail OFF the mail server. Evolution's native Exchange works jut like Outlook, keeping mail ON the serve.r
I've opened up PR #304 where the old install.rdf
is replaced with manifest.json
.
Since Ubuntu still hasn't rolled out Thunderbird 68, maybe someone can test this PR and report back what is broken. I imagine a lot of permissions will be missing.
@advancingu Could you give some details around testing this? I've successfully checked out, built and installed 5.0.0-beta2 from the 277-thunderbird-67-compatibility branch. As you suggest, it isn't working, so I'd like to get you a detailed report.
I don't see any errors related to permissions (but I'm probably not looking in the right place). My existing exchange calendars are greyed out, and the option to add a new exchange calendar is not present in New Calender
=> On the Network
I'm running TB 68.1.0 on OpenBSD-current
Hi folks,
the JS Console showed these errors when trying to use the 277-thunderbird-67-compatibility branch. I am at 7ea16eefd608d3bfc27329b632f32daecf70eea4 using an empty TB 68.0 Profile and an empty TB 68.1.1 Profile
1570433280058 addons.webextension.
Furthermore the thundernest-addons-linter reports: Validation Summary:
errors 0
notices 0
warnings 3
WARNINGS:
Code Message Description File Line Column
CSS_SYNTAX_ERROR Unknown word An error was found in the CSS file being processed as a result further processing of that file is not possible common/theme/common/delegateCalendar.css 20 25
CSS_SYNTAX_ERROR Unclosed block An error was found in the CSS file being processed as a result further processing of that file is not possible common/theme/mac/attachments-view.css 12 1
CSS_SYNTAX_ERROR Unexpected } An error was found in the CSS file being processed as a result further processing of that file is not possible common/theme/common/priority-display.css 544 1
Hi folgs,
this patch fixes the CSS errors:
diff --git a/common/theme/common/delegateCalendar.css b/common/theme/common/delegateCalendar.css index 7d04bdd..54168cd 100644 --- a/common/theme/common/delegateCalendar.css +++ b/common/theme/common/delegateCalendar.css @@ -17,7 +17,7 @@ }
-listitem[selected] { // or listitem[selected=true] +listitem[selected] { / or listitem[selected=true] / background-color: red; color: yellow; } @@ -69,4 +69,4 @@ treechildren::-moz-tree-checkbox(disabled) Firefox 1, 2, and 3 in Mac OS X, so you should specify a URL to an image in your extension or elsewhere. */ list-style-image: url("chrome://global/skin/checkbox/cbox-check-dis.gif"); -} \ No newline at end of file +} diff --git a/common/theme/common/priority-display.css b/common/theme/common/priority-display.css index 2107073..9054f12 100644 --- a/common/theme/common/priority-display.css +++ b/common/theme/common/priority-display.css @@ -540,7 +540,7 @@ border-color: #993399; }
-text-shadow: white 0 -2px;} +text-shadow: white 0 -2px; }
background-color: #663366 !important;
diff --git a/common/theme/mac/attachments-view.css b/common/theme/mac/attachments-view.css index 657c699..8d142a7 100644 --- a/common/theme/mac/attachments-view.css +++ b/common/theme/mac/attachments-view.css @@ -13,6 +13,7 @@
list-style-image: url(chrome://calendar-common/skin/calendar-toolbar.svg#attach);
} +}
toolbar[brighttext] #exchWebService-add-attachment-button { list-style-image: url(chrome://calendar-common/skin/calendar-toolbar.svg#attach-inverted);
Hi folks,
when "fixing" the manifest.json this way:
diff --git a/manifest.json b/manifest.json index 4b5ed94..1b9ed70 100644 --- a/manifest.json +++ b/manifest.json @@ -9,10 +9,12 @@ "name": "Exchange Calendar", "description": "Synchronize calendars, tasks, and contacts with Microsoft Exchange.", "version": "5.0.0.2",
The missing entry in the Lightning new calendar dialog re-appears, but a ton of error messages are shown in the JS console. They all (seem) to be related to the Ci and Cc "imports" -- the one thing that changed massively in recent TB versions.
Looks like there is hope, it's "just" a bit work.
BTW, "version_name" seems to be unsupported by TB (and FF).
Reading https://blog.mozilla.org/thunderbird/2019/10/thunderbird-enigmail-and-openpgp/, I wonder if ExchangeCalendar is in some similar situation regarding availability of required interfaces in future TB versions. Would it make sense to reach out to TB , specifically folks involved in Lighting, to develop a strategy? Or is this already happening? (/me nervous of eventually having to use the davmail cr... again)
Reading https://blog.mozilla.org/thunderbird/2019/10/thunderbird-enigmail-and-openpgp/, I wonder if ExchangeCalendar is in some similar situation regarding availability of required interfaces in future TB versions. Would it make sense to reach out to TB , specifically folks involved in Lighting, to develop a strategy? Or is this already happening? (/me nervous of eventually having to use the davmail cr... again)
There are two mail threads on tb-planning about exchange in general and this addon in special spread from August to October: https://mail.mozilla.org/pipermail/tb-planning/ (Ctrl+F for "exchange" in the mentioned months).
@wagner-certat Thanks for the hint. Looks like TBSync+EAR can actually be an alternative. Evaluating...
@wagner-certat @jan-kiszka I am not familiar neither with TBSync, nor EAR. In our organization somebody was using TBSync with EAS provider and it stopped working for him already in June due to some EAS policy change (confirmed by IT department). Note, I am not familiar with EAS as well. This is a big organization, so there is not much chance that the policy will change to more relaxed one. So please do not make an assumption yet that TBSync would be the solution for everyone instead of this plugin.
@attila123 Yes, being in a large corp as well, I know such surprises. Fortunately, we developed some more direct channel to our IT over the years, though we do not always get what we ask for.
I'm not assuming all issues are solved with TBsync+EAS (not EAR - typo), e.g. I can't accept/reject invitations. At least my most urgent problem is now solved: direct access to my calendar, including reminders.
I would be glad to see ExchangeCalendar working again, even though it had its issues as well (frequently broken accept/reject, often stale caches, likely across roaming situations). If there is something I can help with and that is only of moderate effort, I'll try my best.
Regarding DavMail as alternative, I would be OK with that, probably works even better than this plugin, but it has this annoying problem with Thunderbird, which I reported a few days ago: https://github.com/mguessan/davmail/issues/62
So that day came. Ubuntu has updated to 19.10, and TB ver is 68 now out of the box, so this addon is rendered unusable.
I am using DavMail and it "works" .... but this plugin works so much better! I am missing it already. DavMail for me is a stop-gap solution until this gets fixed and I am confident that it will be. I wish I had the know-how to offer development assistance. I appreciate all that do!
After some month where TB (release channel) stayed on 60.x, it now decided to upgrade to 68.2. Plugin broken. Thank you guys @Mozilla for your wisdom!
They had to solve an issue with google oauth and it was going to happen eventually anyway @olivercarl .
+1
Hi, is there any ongoing work on this. On TBSync I read that there is an interest in using TBSync and using this as an interface to provide EWS. Would that allow to make this plugin again compatible with TB > 60?
I currently pinned the thunderbird versions down to 60 and thus, avoid upgrades but today I had to recompile and install an older version of a first library (icu) which was bumped up too. This is going to get more and more ugly as time progress.
Security alerts like https://www.mozilla.org/en-US/security/advisories/mfsa2019-35/ have kept me from being able to avoid upgrading Thunderbird. Certainly open to helping to test fixes.
I started a WIP at #309, which was mostly search and replace of imports so far. It is possible to install the plugin and open the calendar creation menu, but then i get an error from some lightning internals i don't understand. If anybody is willing to continue this work/help me out, go ahead!
I built your WIP branch and tried to install it and got this when installing it:
1574876824976 addons.xpi WARN Failed to parse recommendation: TypeError: NetworkError when attempting to fetch resource. No traceback available
console.log: WebExtensions: Legacy WebExtension github.com_exchangecalendar@community.invalid has already been loaded in this run, refusing to do so again. Please restart.
JavaScript error: , line 0: uncaught exception: undefined
Extension error: Error while loading 'jar:file:///usr/lib/thunderbird/extensions/messagingmenu@mozilla.com.xpi!/manifest.json' (NS_ERROR_FILE_NOT_FOUND) resource://gre/modules/Extension.jsm:513 :: readJSON/</<@resource://gre/modules/Extension.jsm:513:20
onStopRequest@resource://gre/modules/NetUtil.jsm:128:9
1574877083245 addons.xpi WARN Exception running bootstrap method startup on messagingmenu@mozilla.com: Error: Error while loading 'jar:file:///usr/lib/thunderbird/extensions/messagingmenu@mozilla.com.xpi!/manifest.json' (NS_ERROR_FILE_NOT_FOUND)(resource://gre/modules/Extension.jsm:513:20) JS Stack trace: readJSON/</<@Extension.jsm:513:20
onStopRequest@NetUtil.jsm:128:9
The first line appears when I select the xpi file. The second after pressing add
. The rest one when pressing the restart button
.
After that, there's some more console log and this:
console.log: WebExtensions: Loading add-on preferences from /home/matthias/.thunderbird/tuyf1fcy.default/extensions/github.com_exchangecalendar@community.invalid.xpi
console.log: WebExtensions: Firing profile-after-change listeners for github.com_exchangecalendar@community.invalid
JavaScript error: jar:file:///home/matthias/.thunderbird/tuyf1fcy.default/extensions/github.com_exchangecalendar@community.invalid.xpi!/addressbook/interface/exchangeAbDirFactory/exchangeAbDirFactory.js, line 28: NS_ERROR_FILE_NOT_FOUND:
console.warn: Overlays.jsm: Could not resolve 1 references Array [{}]
After that there seems to be a large output of calendar items with Thunderbird coming up as well. It also seems to clear the console output when printing those calendar item, so to get this block of messages I have to kill thunderbird at the right point in time - otherwise I can't access them.
The exchangecalendar
addon does not appear in the list afterwards. This is with thunderbird version 1:68.2.1+build1-0ubuntu0.18.04.1
.
Security alerts like https://www.mozilla.org/en-US/security/advisories/mfsa2019-35/ have kept me from being able to avoid upgrading Thunderbird. Certainly open to helping to test fixes.
At least for the Ubuntu users among us who don't mind downgrading to version 60, the Mozilla ESR PPA is an option. I would hope that if this version is affected by the mentioned vulnerability it would be fixed there as well.
So that's my way to go until this is resolved for version 68. I need to access various exchange calendars, but I also don't know anything about neither the Mozilla ecosystem nor Javascript. If time permits I can test a reasonably stable version.
Any chance that the extension will become soon compatible with TB 68 ?
@matthiashh: Thank you for your tests. It appears as your errors stem from having installed the extension in a profile where the data of a previous installation is still there (something that, of course, should work, but i haven't gotten that far yet). If you try to install the WIP on a new profile, it should be possible to install (although it is still far from usable).
At least for the Ubuntu users among us who don't mind downgrading to version 60, the Mozilla ESR PPA is an option.
Thanks @matthiashh, this was useful for me to downgrade to Thunderbird 60 until the Exchange Calendar plugin is comptabile with Thunderbird 68. For those like me who don't mind waiting, this is the procedure I used to downgrade Thunderbird from version 68 to version 60 on Ubuntu 18.04 (see also here):
# add the Firefox ESR repository
sudo add-apt-repository ppa:mozillateam/ppa
sudo apt-get update
# find Thunderbird version 60
sudo apt policy thunderbird
Installed: 1:68.2.1+build1-0ubuntu0.18.04.1
Candidate: 1:68.2.1+build1-0ubuntu0.18.04.1
Version table:
*** 1:68.2.1+build1-0ubuntu0.18.04.1 500
500 http://gb.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages
100 /var/lib/dpkg/status
1:60.6.0+build1-0ubuntu0.18.04.1~mt1 500
500 http://ppa.launchpad.net/mozillateam/ppa/ubuntu bionic/main amd64 Packages
1:52.7.0+build1-0ubuntu1 500
500 http://gb.archive.ubuntu.com/ubuntu bionic/main amd64 Packages
# install Thunderbird version 60
sudo apt install thunderbird=1:60.6.0+build1-0ubuntu0.18.04.1~mt1
# (optional) lock this version of Thunderbird to hold back future updates
sudo apt-mark hold thunderbird
The apt install
command may warn you that it'll delete some packages related to Lightning (in my case it was xul-ext-lightning
). I simply reinstalled the Lightning plugin after restarting Thunderbird 60 and my calendars displayed fine again with the Exchange Calendar plugin.
Hope it helps someone else...
I'm unable to login. Even no dialog for password is open. When I hard-code PWD it's able to contact Exhg server but no calendar is created
how is this ongoing any news on plgin update to work on 68 version
At least for the Ubuntu users among us who don't mind downgrading to version 60, the Mozilla ESR PPA is an option.
Thanks @matthiashh, this was useful for me to downgrade to Thunderbird 60 until the Exchange Calendar plugin is comptabile with Thunderbird 68. For those like me who don't mind waiting, this is the procedure I used to downgrade Thunderbird from version 68 to version 60 on Ubuntu 18.04 (see also here):
# add the Firefox ESR repository sudo add-apt-repository ppa:mozillateam/ppa sudo apt-get update # find Thunderbird version 60 sudo apt policy thunderbird Installed: 1:68.2.1+build1-0ubuntu0.18.04.1 Candidate: 1:68.2.1+build1-0ubuntu0.18.04.1 Version table: *** 1:68.2.1+build1-0ubuntu0.18.04.1 500 500 http://gb.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages 500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages 100 /var/lib/dpkg/status 1:60.6.0+build1-0ubuntu0.18.04.1~mt1 500 500 http://ppa.launchpad.net/mozillateam/ppa/ubuntu bionic/main amd64 Packages 1:52.7.0+build1-0ubuntu1 500 500 http://gb.archive.ubuntu.com/ubuntu bionic/main amd64 Packages # install Thunderbird version 60 sudo apt install thunderbird=1:60.6.0+build1-0ubuntu0.18.04.1~mt1 # (optional) lock this version of Thunderbird to hold back future updates sudo apt-mark hold thunderbird
The
apt install
command may warn you that it'll delete some packages related to Lightning (in my case it wasxul-ext-lightning
). I simply reinstalled the Lightning plugin after restarting Thunderbird 60 and my calendars displayed fine again with the Exchange Calendar plugin.Hope it helps someone else...
You made my day !
I would add to your comment : apt install xul-ext-lightning=1:60.6.0+build1-0ubuntu0.18.04.1~mt1
Thanks again
Any news about bringing add-on up to date? Will it happen? If, when can it be expected?
Any news about bringing add-on up to date? Will it happen? If, when can it be expected?
This is an open source project, it's not backed by any commercial entity so there's no guarantee of when this add-on will be made up to date. Commits, pull-requests, and testing are all ways to help "speed things up".
Thanks @matthiashh, this was useful for me to downgrade to Thunderbird 60 until the Exchange Calendar plugin is comptabile with Thunderbird 68. For those like me who don't mind waiting, this is the procedure I used to downgrade Thunderbird from version 68 to version 60 on Ubuntu 18.04 (see also here):
# add the Firefox ESR repository sudo add-apt-repository ppa:mozillateam/ppa sudo apt-get update # find Thunderbird version 60 sudo apt policy thunderbird Installed: 1:68.2.1+build1-0ubuntu0.18.04.1 Candidate: 1:68.2.1+build1-0ubuntu0.18.04.1 Version table: *** 1:68.2.1+build1-0ubuntu0.18.04.1 500 500 http://gb.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages 500 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages 100 /var/lib/dpkg/status 1:60.6.0+build1-0ubuntu0.18.04.1~mt1 500 500 http://ppa.launchpad.net/mozillateam/ppa/ubuntu bionic/main amd64 Packages 1:52.7.0+build1-0ubuntu1 500 500 http://gb.archive.ubuntu.com/ubuntu bionic/main amd64 Packages # install Thunderbird version 60 sudo apt install thunderbird=1:60.6.0+build1-0ubuntu0.18.04.1~mt1 # (optional) lock this version of Thunderbird to hold back future updates sudo apt-mark hold thunderbird
OK, but this is not available for Ubuntu 19.10 (Eoan). For some reason, they have only Firefox and not Thunderbird in this PPA for Eoan. The only reason I am here is because I upgraded my Ubuntu to Eoan, which upgraded my Thunderbird to 68...
OK, but this is not available for Ubuntu 19.10 (Eoan). For some reason, they have only Firefox and not Thunderbird in this PPA for Eoan. The only reason I am here is because I upgraded my Ubuntu to Eoan, which upgraded my Thunderbird to 68...
Check with dpkg which thunderbird packages you have installed, go to this page and download the packages with the same name (bottom of the page) and install them via dpkg. As a last step, use "apt-mark hold \
Edit: sorry, had the arm64 package linked, not the amd64
I have donated $15 on BountySource.com for resolving this issue: https://www.bountysource.com/issues/84017522-exchange-calendar-is-incompatible-with-thunderbird-68-2-2
Great idea! I was a little worried because the issue referenced was the dup #308 but from their FAQ it looks like that should not be a problem. Hope this helps if a couple more people join in :)
It is not possible to install the XPI of v5.0.0-alpha3 on Thunderbird 67.0b3.
"This add-on could not be installed because it is not compatible with Thunderbird 67.0."
Does anybody happen to know what is necessary to get this to work? I would prefer using the latest release version, but I have a RHEL6 system on which the latest release version of Thunderbird crashes. This beta version works without issues however.