Arby improving suggestions

[raladev]

Arby is in alpha state now and looks unfinished. So, here you can offer any improvement for discussion.

• [ ] if invalid creds are passed to arby, status command should contain message about that, also logs of arby should contain error about bad creds and maybe container should finish work with another exit code (not 0).

• [x] Add info rder that was sent to binance + also i want to see info about binance fill.

• [ ] Maybe it would be better to do not print same price twice or move printing all prices to lower debug level.

• [ ] bestBid and bestAsk monitoring looks like more correct solution then last trade monitoring.

• [ ] Current behavior can be destructive if price will move significantly after binance order placement, if I understood correctly. OpenDex update was stopped by placed but not filled order, so xud node will contain orders with tasty prices.

• is it true that each Opendex trade leads to order canceling untill Binance fill?

• • I haven't implemented this logic yet. Right now it just stops updating orders until Binance order is in progress. It should probably keep updating them or remove all orders until centralized exchange part is done.

• [x] Orders should be canceled if Arby completes its work (for example, because of empty channel of shutting down by user)

• [x] arby is using replace_order_id when issuing new orders, right? I am confused by local xud/arby logs saying removed order and creating new orders, but but there were no remova p2p packets. In that case, I'd remove this arby log statement since it's confusing: [OpenDEX] trace: Removed all open orders for ETH/BTC

[raladev]

• Another thing: you are always using replace_order_id when issuing new orders, right? I am confused by local xud/arby logs saying removed order and creating new orders, but but there were no remova p2p packets. In that case, I'd remove this arby log statement since it's confusing: [OpenDEX] trace: Removed all open orders for ETH/BTC

if there is no real removal/creation then it should be:

1. 'Create order' msg when repalce_id is not used (first time place)
2. 'Order replace' msg when raplce_id is used
3. 'Remove order' msg when there is real order removal

[raladev]

• [ ] it would be good to have cli tool for arby to control it.

For now it is uncontrollable container that starts order placing when see balance in the channel. But it would be good to have at least start/stop commands in docker setup.

[kilrau]

* [ ]  it would be good to have cli tool for arby to control it.

For now it is uncontrollable container that starts order placing when see balance in the channel. But it would be good to have at least start/stop commands in docker setup.

Good idea, but I would rather let xud ctl take care of that: warn & educate user before starting. Offer a command to stop it etc.

[raladev]

• [x] qty of orders should be based on channel balance of both currencies Arby places sell 121 ETH/BTC 0.024499475 order, but I have only 17 ETH in the channel, so it can lead to significant amount of errors during swap Screenshot from 2020-06-15 19-11-07

[kilrau]

Marked above as done, it has its own P1 issue and will be done asap: https://github.com/ExchangeUnion/market-maker-tools/issues/17

[kilrau]

I think we should tackle this one in course of this issue next:

• bestBid and bestAsk monitoring looks like more correct solution then last trade monitoring.