search

ExchangeUnion / xud-docker

Streamlined setup of xud and all dependencies via docker 🐳
https://docs.exchangeunion.com
GNU Affero General Public License v3.0
5 stars 5 forks source link

Configure needed assets #140

Open peartobear opened 5 years ago

peartobear commented 5 years ago

Configuring docker to allow for easily customizable asset choice by picking and choosing nodes and chains to sync would not only save lot of syncing time for people running full nodes but would also allow for a more abstract interface for apps building on top of the deamon. For instance, someone not planning to trade LTC would choose to not sync the litecoin node.

kilrau commented 5 years ago

Part of https://github.com/ExchangeUnion/xud-docker/issues/30

kilrau commented 4 years ago 
Which assets do you plan to trade? Multiple choices separated by comma.
1. BTC
2. LTC
3. ERC20(ETH)
4. ALL
Please choose: 1,3
You selected BTC, ETH-ERC20. Is that correct? [Y/n]
kilrau commented 4 years ago

Also moving this one to the next project.

kilrau commented 4 years ago

Persisted in $NETWORK.conf as boolean for each asset .Default is ALL, user is only asked once, if script is exited or any other sort of error occurs, default (all 1) is set and script continues.

raladev commented 4 years ago

one more suggestion: We can use cmd params approach that we use with optional containers:

  --arby.disabled [ARBY.DISABLED]
  --boltz.disabled [BOLTZ.DISABLED]
  --webui.disabled [WEBUI.DISABLED]

--lndltc.enbaled false (true as default) --lndbtc.enbaled false (true as default) --connext.enbaled false (true as default)

erkarl commented 4 years ago

Bumping this issue as it's annoying to run litecoind and lnd-ltc when I have no interest in using them.

kilrau commented 3 years ago

one more suggestion: We can use cmd params approach that we use with optional containers:

  --arby.disabled [ARBY.DISABLED]
  --boltz.disabled [BOLTZ.DISABLED]
  --webui.disabled [WEBUI.DISABLED]

--lndltc.enbaled false (true as default) --lndbtc.enbaled false (true as default) --connext.enbaled false (true as default)

Actually thinking about this again - this might not be the best option since cli paramters are supposed to be temporary, whereas the selection here is more permanent. I think https://github.com/ExchangeUnion/xud-docker/issues/140#issuecomment-548080872 is the better way for now.

kilrau commented 3 years ago

The xud dependency to initialize swap client at a later point in time finally has a PR: https://github.com/ExchangeUnion/xud/pull/1961

This allows us to do the following in the course of this issue (best to split into several PRs):

  1. cli parameter + conf choice of assets: 
    --lndltc.enbaled false (true as default)
--lndbtc.enbaled false (true as default)
--connext.enbaled false (true as default)
  2. interactive choice of assets in create: 
    
Which assets do you plan to trade? Multiple choices separated by comma.
  3. BTC
  4. LTC
  5. ERC20(ETH)
  6. ALL Please choose: 1,3 You selected BTC, ETH-ERC20. Is that correct? [Y/n]
  7. Add asset any time during runtime: addcurrency should detect that currency (e.g. LTC) is supported, pull lndltc container, start it and initialize via https://github.com/ExchangeUnion/xud/pull/1961
kilrau commented 3 years ago

We need this feature for Raspiblitz to start the environment with --lndltc.enbaled false there.