search

ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 44 forks source link

Subscribing to single order stream is not working as a maker #1339

Open ghost opened 5 years ago

ghost commented 5 years ago

The optional --stream parameter for placing the order is only working as a taker.

After looking at the codebase it is not trivial to fix because of the mechanics of the flow of onUpdate callback: https://github.com/ExchangeUnion/xud/blob/master/lib/orderbook/OrderBook.ts#L524

The current workaround is to subscribe to events from all orders instead.

kilrau commented 4 years ago

I'm confident arby/hedgy will need this.

engwarrior commented 4 years ago

Pls provide estimate for this task.

ghost commented 4 years ago

I'm confident arby/hedgy will need this.

I've worked around it by subscribing to all swaps and matching the order ID on hedgy/arby's side.

kilrau commented 4 years ago

Moved this to next milestone since @erkarl worked around it @sangaman . Added estimation @engwarrior