ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 49 forks source link

[xud-backup] Backup & Restore TOR data + xud.conf #1416

Open kilrau opened 4 years ago

kilrau commented 4 years ago
kilrau commented 4 years ago

@michael1011

sangaman commented 4 years ago

I can somewhat understand backing up the xud.conf file, backing up configuration is uncommon afaik but it wouldn't hurt and it would be simple to add.

I don't understand backing up the tor/tor-data folders, what's the purpose here? I also don't know where those directories will exist, would there be permissions concerns?

erkarl commented 4 years ago

I don't understand backing up the tor/tor-data folders, what's the purpose here?

This is to ensure that the restored node gets the same hash.onion URL.

I also don't know where those directories will exist, would there be permissions concerns?

I think this issue belongs to xud-docker repository as the paths there are known and there will not be permission issues.

sangaman commented 4 years ago

This is to ensure that the restored node gets the same hash.onion URL.

Is this important? What would be the harm in using a different tor address?

kilrau commented 4 years ago

I see people publishing their xud uris on websites like we currently see happening with lightning. At least always-on market makers and service providers which have their uris as seed node entry in xud would not want their xud onion uri to change.

But agree that this only becomes important after the OpenDEX network reaches a certain size, hence agree that it is not high prio. Ill move this further down the line.

erkarl commented 4 years ago

Is this important? What would be the harm in using a different tor address?

More like nice to have, yes. Good point.