search

ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 44 forks source link

Incorrect sort order in sortOrders function #1886

Open raladev opened 4 years ago

raladev commented 4 years ago

https://github.com/ExchangeUnion/xud/blob/aa41615a82475193b02f55427272562bb01a3cdd/lib/utils/utils.ts#L197

based on https://github.com/ExchangeUnion/xud/pull/1883#pullrequestreview-485582195

kilrau commented 4 years ago

Since this is a breaking, non-trivial change that only appears on the gRPC and https://github.com/ExchangeUnion/xud/pull/1883 fixed the only place in the xucli where this surfaces, I'm inclined to not touch this any time soon :/