xud is going from checking for hold invoice support to getting unexpectedly marked as disconnected then back to "connection verified" a moment later but can't set it to state "connection verified" because cannot set status to ConnectionVerified from NoHoldInvoiceSupport
How it should be
xud shouldn't mark the state as NoHoldInvoiceSupport if it's a generic error when trying to add the invoice. xud should only mark state as NoHoldInvoiceSupport if it gets a specific "hold incoice not supported" error from lnd, tbd how this error looks like
xud should allow setting state from NoHoldInvoiceSupport to ConnectionVerified - e.g. when the user fixed up the lnd. If that breaks other things, we can leave it as is and print something about "restart required".
How it is
xud is going from checking for hold invoice support to getting unexpectedly marked as disconnected then back to "connection verified" a moment later but can't set it to state "connection verified" because
cannot set status to ConnectionVerified from NoHoldInvoiceSupport
How it should be
NoHoldInvoiceSupport
if it's a generic error when trying to add the invoice. xud should only mark state asNoHoldInvoiceSupport
if it gets a specific "hold incoice not supported" error from lnd, tbd how this error looks likeNoHoldInvoiceSupport
toConnectionVerified
- e.g. when the user fixed up the lnd. If that breaks other things, we can leave it as is and print something about "restart required".