ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 49 forks source link

NoHoldInvoiceSupport Fixes #1968

Closed kilrau closed 3 years ago

kilrau commented 3 years ago

How it is

xud is going from checking for hold invoice support to getting unexpectedly marked as disconnected then back to "connection verified" a moment later but can't set it to state "connection verified" because cannot set status to ConnectionVerified from NoHoldInvoiceSupport

How it should be

  1. xud shouldn't mark the state as NoHoldInvoiceSupport if it's a generic error when trying to add the invoice. xud should only mark state as NoHoldInvoiceSupport if it gets a specific "hold incoice not supported" error from lnd, tbd how this error looks like
  2. xud should allow setting state from NoHoldInvoiceSupport to ConnectionVerified - e.g. when the user fixed up the lnd. If that breaks other things, we can leave it as is and print something about "restart required".