search

ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 49 forks source link

refactor(rpc): rename reserved TradingLimits fields #1980

Closed sangaman closed 3 years ago

sangaman commented 3 years ago

This renames the reservedOutbound and reservedInbound fields on the TradingLimits call to reservedSell and reservedBuy respectively.

This is take two for #1946, which was reverted shortly after being merged to prevent conflicts with xud-ui. Whenever the ui project is ready for these new names we should merge this for good.

kilrau commented 3 years ago

Nice - let's get it in with the next release then!

raladev commented 3 years ago

we already have identical PR for that - https://github.com/ExchangeUnion/xud/pull/1954 )

kilrau commented 3 years ago

we already have identical PR for that - #1954 )

True, closing here.

erkarl commented 3 years ago

Thanks @sangaman