kilrau
commented
3 years ago add sentence after password changing lnd restart is required to Apply change to lnd.
Not needed since lnd is in unlocked state in this moment and continues to be fully functioning. Next time the environment/lnd restarts, the new password is active, I don't see any reason to trigger a restart / ask the user to restart lnd (and this is probably also the reason why the lightning labs team decided not to do that on lnd).
it would be good to support conception of password changing -> Enter old password -> Enter new password -> Re-enter new password. I dont like the idea that anyone can change password without any additional data if node is unlocked (even if anyone can withdraw all crypto if node is unlocked :) ).
Yep, agree (and lnd requires current password first too, it's convention):
lncli changepassword
Input current wallet password:
Input new wallet password:
Confirm new wallet password: suggestion: make wrapper on xud-docker side for changepass call that will restart lnds automatically;
As i said above, don't think that's needed.
got err when tried to unlock the node after password changing + my lnd were not unlocked on xud unlock (I unlocked it manually using old password)
Just to be clear what happened @sangaman : Roman used changepass of a running xud-docker env, which seemingly succeeded, then downed the env, borught it up again and unlocked with the new password. xud unlocked with new password, lnd didn't. Manually unlocking lnd with the OLD password worked. So somehow that password change for lnd covertly failed - that is the major bug to be fixed.
sangaman
raladev
erkarl
This adds the ability to change the master password of an existing xud node. Changing the password re-encrypts the node key on disk and queues password changes for all lnd wallets.
Lnd does not currently offer the ability to change the password of an unlocked, running instance. Instead lnd can only change its password right after being started while it is still locked. Xud therefore saves the old password for each lnd wallet to the xud database and encrypts the old password using the new passwords. On subsequent unlocks of xud, when we go to unlock lnd wallets we first check whether we have any old passwords in the database corresponding to any lnd wallets. If we do, we decrypt the old password and change the password for lnd, which in turn will unlock lnd.
Closes #1981.
Note that this also introduces a framework for tracking a database's version and migrating from one version to the next when the database schema needs to be modified. The migrations consist of an array of methods that each are responsible for upgrading from a particular version, and they are run in sequence when we detect that the current database version is lower than the latest version.
The xucli command is
changepass.