search

ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 49 forks source link

fix(rpc): 0 remaining quantity on full remove #2022

Closed sangaman closed 3 years ago

sangaman commented 3 years ago

This fixes a bug where fully removing an order via RemoveOrder would return the entire quantity of the order as the remaining quantity instead of zero. The problem was that when removing a quantity in full, we would simply delete it from our collection of orders but not modify its quantity, which is used (since #1986) for informational purposes on the rpc response.

It also tidies up the cli output a bit so as not to display zero amounts for holds or remaining quantity.

Fixes #2020

sangaman commented 3 years ago

@raladev thanks for catching, can you check again?