ExchangeUnion / xud

Exchange Union Daemon 🔁 ⚡️
https://exchangeunion.com
GNU Affero General Public License v3.0
115 stars 49 forks source link

style: add airbnb-typescript eslint rules #2034

Closed sangaman closed 3 years ago

sangaman commented 3 years ago

This adds and enforces airbnb typescript linting rules to eslint to approximate the rules from the prior tslint implementation. Several new rules are enforced compared to tslint, and several new rules have been disabled if they introduced too much change from the existing code.

This also adds the eslint prettier config rules to prevent overlap and conflicts with prettier for strictly stylistic/formatting rules.

The linting for tests is still pretty limited, but it was limited before as well.

erkarl commented 3 years ago

Linter is not passing for the latest commibt build.

sangaman commented 3 years ago

Linter is not passing for the latest commibt build.

Fixed, prettier was moving an eslint-disable-line comment from one line to the next. I also fixed a conflict with the custom-xud patch, tests are passing now.

erkarl commented 3 years ago

Awesome. Thanks.