ExcitedStates / qfit-3.0

qFit: Automated and unbiased multi-conformer models from X-ray and EM maps.
MIT License
34 stars 11 forks source link

qfit_ligand assigns occupancies in only a specific range (0.2-0.35):bug: #315

Closed ss199514 closed 3 months ago

ss199514 commented 1 year ago

Describe the bug qfit_ligand is consistently assigning occupancies in the range of 0.2-0.35 for >40 PDBs (5-6 different datasets). It assigned an occupancy of 0.2 for the majority of these datasets.

To Reproduce Steps to reproduce the behavior: Step 1--> Fetch files

Use get_structures.sh (phenix.fetch_pdb –mtz)

Step 2--> Running ready set

Original.pdb (from the PDB fetched ^^)

Step 3--> Generate composite omit map

phenix.composite_omit_map original.pdb phenix_fetch_sf.mtz ../ready_set/*.ligands.cif input.xray_data.labels=FOBS,SIGFOBS input.xray_data.r_free_flags.label=R-free-flags

Step 4--> Run qfit_ligand

qfit_ligand composite_omit_map.mtz -l 2FOFCWT,PH2FOFCWT original.pdb chain,number

Expected behavior An inspection of the occupancies assigned by qfit_ligand will show that it's skewed towards ~0.2

Additional context Examples structures to test this on: 7ZWO,7ZWP,7ZWQ,7ZWR,7ZWS,7ZWT,7ZWU,7ZWV,7ZWW,7ZWX,7ZWY,7ZWZ

Software & OS Version:

Attach files:

v3.2.0_multiconformer_A_201.txt

stephaniewankowicz commented 1 year ago

@ss199514 did you re-test these PDBs and get higher occupancies? The deposited occupancies for many of these ligands are less than 1. Was the sum of occupancies closer to 0.5 or higher? Just trying to figure out if we should close this issue or not.

stephaniewankowicz commented 3 months ago

Re-worked with @jessicaflowers changes