Exercise / HTMLPurifierBundle

HTML Purifier is a standards-compliant HTML filter library written in PHP.
http://htmlpurifier.org/
Other
275 stars 56 forks source link

Upgrade DependencyInjection to Symfony 2.7 #25

Closed althaus closed 9 years ago

althaus commented 9 years ago

This checks if "setFactory" is available in favor of "setFactoryClass".

MasterB commented 9 years ago

+1

pzorn commented 9 years ago

+1

spolischook commented 9 years ago

Update dependencies in composer.json

althaus commented 9 years ago

@spolischook You mean enforcing Symfony 2.7 in the deps? My fix doesn't change the minimal required version.

jbgomond commented 9 years ago

:+1:

spolischook commented 9 years ago

it's add Symfony 2.7 support? Other parts is work good with 2.7?

jbgomond commented 9 years ago

Yes, this was the code triggering deprecated notices.

althaus commented 9 years ago

Other parts is work good with 2.7?

Yes, I haven't found any other issue yet.

Symfony 2.7 deprecates the setFactoryClass and setFactoryMethod methods in favor of a combined setFactory call:

https://github.com/symfony/symfony/blob/2.7/UPGRADE-3.0.md#dependencyinjection

jbgomond commented 9 years ago

Could somebody merge it ? ping @cystbear

ghost commented 9 years ago

+1. Could we merge this upstream? ping @spolischook

cystbear commented 9 years ago

@althaus does this stuff works? /cc @MJBGO @edvinasme

althaus commented 9 years ago

@cystbear Yes, our fork runs fine with 2.7 in our dev environment. The fix isn't big magic.

jbgomond commented 9 years ago

:+1: Works for me, it is just replacing the old methods by the new ones ;)

spolischook commented 9 years ago

Thanks for contributing!

althaus commented 9 years ago

@spolischook Thanks for the merge. Could you tag a new release for Composer?