Closed althaus closed 9 years ago
+1
+1
Update dependencies in composer.json
@spolischook You mean enforcing Symfony 2.7 in the deps? My fix doesn't change the minimal required version.
:+1:
it's add Symfony 2.7 support? Other parts is work good with 2.7?
Yes, this was the code triggering deprecated notices.
Other parts is work good with 2.7?
Yes, I haven't found any other issue yet.
Symfony 2.7 deprecates the setFactoryClass
and setFactoryMethod
methods in favor of a combined setFactory
call:
https://github.com/symfony/symfony/blob/2.7/UPGRADE-3.0.md#dependencyinjection
Could somebody merge it ? ping @cystbear
+1. Could we merge this upstream? ping @spolischook
@althaus does this stuff works? /cc @MJBGO @edvinasme
@cystbear Yes, our fork runs fine with 2.7 in our dev environment. The fix isn't big magic.
:+1: Works for me, it is just replacing the old methods by the new ones ;)
Thanks for contributing!
@spolischook Thanks for the merge. Could you tag a new release for Composer?
This checks if "setFactory" is available in favor of "setFactoryClass".