search

Exercise / HTMLPurifierBundle

HTML Purifier is a standards-compliant HTML filter library written in PHP.
http://htmlpurifier.org/
Other
275 stars 56 forks source link

use PSR-4 autoloading. #29

Closed bangpound closed 9 years ago

bangpound commented 9 years ago

This flattens out the directory structure in vendor (and closes out all my reasons for forking this bundle).

tgabi333 commented 9 years ago

+1

spolischook commented 9 years ago

+2, why you need this? what that broken?

bangpound commented 9 years ago

It flattens the directory structure and makes it much easier to navigate my vendor directory and make patches that I can contribute upstream. It's a small thing, but it makes a difference to how easy is it would be to contribute to this project.

spolischook commented 9 years ago

nice, is it broke some backward compatibility? especially interested Symfony 2.3

bangpound commented 9 years ago

I do not believe that this will not break backward compatability with Symfony. Instead, it simply requires a newer version of Composer to support PSR-4 autoloading. Composer has supported PSR-4 since January 2014 and there have been 2 or 3 alpha releases since this feature was added.

stof commented 9 years ago

@spolischook no BC break at all, as Symfony does not hardcode anything related to bundle locations since 2.1+. It relies on autoloading to find their location.

:+1: for this as the target-dir setting in Composer is considered legacy (it was implemented because we were missing PSR-4 at that time, to cover 1 subcase of PSR-4)

spolischook commented 9 years ago

https://github.com/Exercise/HTMLPurifierBundle/releases/tag/v0.2.2