Exercise / HTMLPurifierBundle

HTML Purifier is a standards-compliant HTML filter library written in PHP.
http://htmlpurifier.org/
Other
275 stars 56 forks source link

Switch the Twig integration to use non-deprecated APIs #30

Closed stof closed 9 years ago

stof commented 9 years ago

This makes the bundle compatible with Twig 2.0 and avoids the deprecation warning in 1.21+

spolischook commented 9 years ago

any broken BC?

stof commented 9 years ago

@spolischook this requires Twig 1.12 to work. but symfony already depends on Twig 1.12 since years, and even on higher versions than that in latest releases (it will soon depend on 1.20+)

spolischook commented 9 years ago

What last version of Symfony didn't works with this changes?

stof commented 9 years ago

@spolischook all versions of Symfony work with the latest Twig 1.x version (Twig maintained BC strictly in the full 1.x lifetime). Symfony 2.3.0 forced to have at least 1.12 for Twig, so people using Symfony 2.3+ are known to be safe. In older versions of Symfony, the min requirement for Twig was lower than that, bit the default version shipped in the SE was still the latest Twig release at that time. So this can only break things for people who are using a totally unmaintained Symfony versions (2.2 is unmaintained since years, even for security patches) and have never updated their Twig version (which is possible even for them). Such people are unlikely to update the bundle to this version.

spolischook commented 9 years ago

nice

XWB commented 9 years ago

@spolischook Is it possible to create a new tag (v0.2.1) ?

spolischook commented 9 years ago

@XWB done https://github.com/Exercise/HTMLPurifierBundle/releases/tag/v0.2.1

XWB commented 9 years ago

Thank you very much!

tgabi333 commented 9 years ago

Thanks

tgabi333 commented 9 years ago

Could you please publish it to packagist too?

stof commented 9 years ago

@spolischook you should configure the Packagist hook on the repo so that it happens automatically and quickly (instead of relying on the daily/weekly cron running for other packages)

spolischook commented 9 years ago

Unfortunately have no access to configure this bundle. @wizardz has.