Support PHP 8.0 - Githubissues

Exercise / HTMLPurifierBundle

HTML Purifier is a standards-compliant HTML filter library written in PHP.

http://htmlpurifier.org/

Other

275 stars 56 forks source link

Closed pierres closed 3 years ago

HeahDude commented 3 years ago

Hello @pierres, many thanks for that PR! And happy holidays to you!

Could you please try to declare "XDEBUG_MODE=coverage" using the phpunit.xml.dist? The CI is currently failing on the coverage step: https://travis-ci.org/github/Exercise/HTMLPurifierBundle/builds/751811763.

HeahDude commented 3 years ago

Just noticed that the Xdebug issue is not caused by your changes, sorry. Thanks for working on it though.

pierres commented 3 years ago

Yes, the Xdebug issue was unrelated and caused by the Xdebug 3 update. I rebased the PR to have two separate commits.

HeahDude commented 3 years ago

Thank you @pierres for this nice contribution, 3.1 is now tagged :).

Happy holidays!