search

Exeu / Amazon-ECS-PHP-Library

This library is no longer maintained! Please have a look at my new amazon Lib at: https://github.com/Exeu/apai-io
https://github.com/Exeu/apai-io
GNU General Public License v3.0
238 stars 97 forks source link

Added sortParam method #27

Closed Shimin-Zhang closed 12 years ago

Shimin-Zhang commented 12 years ago

Hi Exeu,

Sorry I'm quite new with the whole github thing (and programming in general), I edited a bit of the ECS class added an optional parameter function sortParam and changed the page function's validation since I think 10 is the maximum page number at the moment. I hope it's helpful with the library, if not feel free to ignore the pull request!

john

Exeu commented 12 years ago

Hi, thanks for your efforts. Could you plese correct the Doc Block of the new function? There has to be a Whitespace Character between the "*" and the Text like in the other functions above.

Thanks

Exeu commented 12 years ago

ping

Exeu commented 12 years ago

I will close now

Shimin-Zhang commented 12 years ago

Sorry about that Jan, I was thinking of adding a few more functions before fixing the comments. Anything else you think might be useful in particular?

Exeu commented 12 years ago

Hi,

actually i think there is nothing which should be implemented in this class. The only thing i thought about is the limitation of the page parameter which you have set to 10. In my opinion this check could be removed because if your are going to enter a higher number there will be no error or something else. So if amazon decides to increase this value this class must not be touched again.