Exifly / ApiVault

Your gateway to a world of public APIs.
https://apivault.dev
Other
442 stars 40 forks source link

change theme mode button into a toggle #166

Closed gdjohn4s closed 1 year ago

gdjohn4s commented 1 year ago

Is your feature request related to a problem? Please describe

No, there isn't problems with theme mode button, but i believe is better using a toggle to switch from light to dark. This issue thread can be using as a discussion to discuss for alternatives.

Describe the solution you'd like

The solution i had in mind is like this screenshot. When toggle is triggered it switch color scheme. Like this:

image

Additional context

If you have better ideas feel free to write here.

Vishal77fsd commented 1 year ago

hey @gdjohn4s would you like to elaborate more about the problem

gdjohn4s commented 1 year ago

hi @vishal7738639800 there isn't no problem with this issue, just a modification to the theme button switcher

Badrnyali commented 1 year ago

hi @vishal7738639800 i'm also interested about this issue. You can pass it to me if you don't want it )

FlavioAdamo commented 1 year ago

@vishal7738639800 We would like to replace the dark mode/light mode button with a switch. If you don't want to work on this issue we will assign it to @Badrnyali .

Thanks in advance to both of you <3

Manuel-Suarez-Abascal commented 1 year ago

@gdjohn4s @FlavioAdamo do we want to use the switch toggle with custom CSS code or do you have any recommendation for a Vue's switch toggle component?

gdjohn4s commented 1 year ago

@Manuel-Suarez-Abascal Vuetify framework has a Switch component but i think it's better to create our own for now (just to avoid implementing a single component of a large framework). I found a codepen for a complete CSS switch, what do you think about?

cyberGHostJs commented 1 year ago

hi, i worked on replacing the theme mode button with a toggle on a different branch and this is what it looks like now. Screen Shot 2023-05-17 at 9 58 26 AM

Screen Shot 2023-05-17 at 9 58 40 AM you can merge it if you're okay with it. or point out what you'd like me to adjust.

gdjohn4s commented 1 year ago

@cyberGHostJs thank you so much! we'll review your PR soon.