Exiled-Team / DiscordIntegration

GNU General Public License v3.0
13 stars 37 forks source link

Fix the bot repeat sending messages #108

Closed jake-baxter closed 2 years ago

jake-baxter commented 2 years ago

Simple fix, I'm mainly a lua person so if it looks weird it looks weird.

Forgot to add the new lines, thats why it was repeating the message as it couldnt find anything to replace.

I haven't tried this because my Visual studio is playing up, but it should in theory work?

jake-baxter commented 2 years ago

To fix this issue btw: https://github.com/Exiled-Team/DiscordIntegration/issues/107

jake-baxter commented 2 years ago

Well I would attempt to see if the fix would work... but my VS2022 installer has a WebView2 installation error 🤦‍♂️

joker-119 commented 2 years ago

msg += split[i] and msg += $"{split[i]}" are the same thing, and the split string will already contain a \n

jake-baxter commented 2 years ago

Alright, fair enough but it does seem like the logs and failing to break new lines in the logs, had a intercom event repeated in my server logs and \n seemed not to appear as all the repeated logs I've had have all been on the same line and wrap around of course when it reaches the limit for the line

jake-baxter commented 2 years ago

Also that above issue, when it does not exceed the character limit, new lines are broke 🤷‍♂️

jake-baxter commented 2 years ago

image Not sure if this uses a different version of .NET or anything, but this doesnt seem to include the splitter