Di but Better - Githubissues

Exiled-Team / DiscordIntegration

GNU General Public License v3.0

13 stars 37 forks source link

Di but Better #57

Closed SrLicht closed 2 years ago

SrLicht commented 3 years ago

Improvements ?

I don't like to compile code, so I made a github action for that, honestly I copied a little (a lot) from the Exiled repository.
csprojec was changed to SDK, I don't know if this is really an improvement. I also fixed the references, sorry for breaking them.
Support of CategoryID instead of ChannelID to register the channels that can use commands. Servers with many channels should thank me.
Now all command responses are embed messages.
- I made a setting in DI plugin to change the embed color.
Things I plan to change:
- Make the embed of the !di playerlist command have the time of the game in the embed title.

https://www.youtube.com/watch?v=5xooMXyleXM

EsserGaming commented 2 years ago

when?

joker-119 commented 2 years ago

when?

I told pietro to review this ages ago but he seems to have fallen off the face of the earth

SrLicht commented 2 years ago

when?

I told pietro to review this ages ago but he seems to have fallen off the face of the earth

Anyway this is broken with the current version of DI, I would ask you to give me a week or two to fix it and optimize it. Although I don't think it is necessary pietro is dead, I have all the time I want. :trollface:

SrLicht commented 2 years ago

@joker-119 I improved my code so that it doesn't give cancer and added a couple of functions, I hope you like them. :flushed: The first comment was edited to show the changes, but I will put it here anyway. Copy paste time

Improvements ?

I don't like to compile code, so I made a github action for that, honestly I copied a little (a lot) from the Exiled repository.
csprojec was changed to SDK, I don't know if this is really an improvement. I also fixed the references, sorry for breaking them.
Support of CategoryID instead of ChannelID(I did not remove this, I simply added the possibility to use the categories) to register the channels that can use commands. Servers with many channels should thank me.
Now all command responses are embed messages.
- I made a setting in DI plugin to change the embed color.
Things I plan to change:
- Make the embed of the !di playerlist command have the time of the game in the embed title.

xRoier commented 2 years ago

This PR should be closed already lol

joker-119 commented 2 years ago

Well pietro was supposed to review this PR a long time ago to look over the nodejs stuff since I'm barely competent with it, but he's disappeared. So I'll be converting the bot back to c# so that I can properly maintain it myself.

And the new C# bot will use embeds with proper formatting and such similar to what's shown in this PR.