search

Exiv2 / exiv2

Image metadata library and tools
http://www.exiv2.org/
Other
885 stars 279 forks source link

Remove the need to enable BMFF via API #2981

Closed kmilos closed 3 weeks ago

kmilos commented 1 month ago

BMFF support is either explicitly removed at build time, or is assumed to be on/available w/o a need for the second gating mechanism.

The Exiv2::enableBMFF(bool) dummy is kept in the API for legacy apps for the time being. (Hopefully no one ever called enableBMFF(false)!?)

This is to remove the somewhat artificial constraint on thread safety.

I'd be bold and backport this to 0.28.x if there are no objections as a step towards leaving the whole BMFF IPR confusion behind... (and remove completely from API on main next?)

kmilos commented 3 weeks ago

@kevinbackhouse Thanks. Any thoughts on backporting this to 0.28.x (and maybe a point release soon for other goodness)?

kevinbackhouse commented 2 weeks ago

@kevinbackhouse Thanks. Any thoughts on backporting this to 0.28.x (and maybe a point release soon for other goodness)?

Sorry I forgot to respond last week. This is fine with me. A point release sounds good too.