added nested object comment

Exlll / ConfigLib

A Minecraft library for saving, loading, updating, and commenting YAML configuration files

MIT License

135 stars 17 forks source link

added nested object comment #8

Closed Draww closed 2 years ago

Draww commented 5 years ago

nested objects can receive a comment. solved #7

Draww commented 5 years ago

if there's a list on the data, there's an error. I'il try to figure it out.

edit: solved

Exlll commented 5 years ago

Hi,

thanks for your contribution, but I'm currently really busy and will have a look into it over the Christmas time. However, here are a few aspects:

Tests should automatically test the behavior and not output something to console.
Perhaps a method in the Comment annotation is better than adding the additional NestedComment annotation.

Draww commented 5 years ago

the reason I added nestedComment annotation was to make sure it didn't search for any other objects but I can listen directly to the sub-objects of the comment and as for the test issue, I did the test for myself. I'il do it again like you said.

Exlll commented 2 years ago

Nested comments are now available with version 3.