search

Exo-TiC / ExoTiC-ISM

This is a repository for the reduction pipeline detailed in Wakeford, et al., 2016, ApJ. The method implements marginalization across a series of models to represent stochastic models for observatory and instrument systematics. This is primarily for HST WFC3, however, may be extended to STIS in the future.
MIT License
8 stars 6 forks source link

Check indexing of pos vector #37

Closed ivalaginja closed 5 years ago

ivalaginja commented 5 years ago

pos filters out only the systematic models with positive AIC. We need to check whether this pos vector actually works as it should when there is at least one sys model with negative AIC, and whether this array cut propagates correctly through the rest of the code.

hrwakeford commented 5 years ago

See comments on issue #39

ivalaginja commented 5 years ago

See this comment of the suggestion of using masked arrays when eliminating models with negative AIC.

ivalaginja commented 5 years ago

@hrwakeford do you have example data that yields negative AIC for some of the systematic models (at least one) so that we can test this?

ivalaginja commented 5 years ago

@hrwakeford I suppose the final output files should save all data without the mask applied to it? I will make sure to save the mask with it so that the user can reconstruct which models where actually used and which ones were masked out.

ivalaginja commented 5 years ago

Dealing with this now over on PR #46.

ivalaginja commented 5 years ago

Closed