Exo-TiC / ExoTiC-LD

Limb-darkening package to calculate the coefficients for specific instruments, stars, and wavelength ranges
https://exotic-ld.readthedocs.io
MIT License
8 stars 6 forks source link

Adding custom input for Issue10 #14

Closed hrwakeford closed 2 years ago

hrwakeford commented 2 years ago

This update allows the user to input a custom throughput profile.

Screenshot 2022-03-15 at 08 41 43

The README.md and limb_darkeing.py files have been updated to include new parameters for this.

The function also works as previously when known modes are called without the need of the new keywords

Screenshot 2022-03-15 at 08 44 24
DavoGrant commented 2 years ago

This looks great. One question: I am wondering if the wsdata input should only have two values (start, stop) corresponding to the wavelength range? np.array([start, stop]) rather than np.arange(start, stop, step)?

hrwakeford commented 2 years ago

The wsdata normally corresponds to the computed wavelength solution of the spectra over the wavelength range you want to consider for your light curve. So the example used here is just a simple array with a step size, but in reality it would likely be a truer representation of the wavelengths considered for that specific light curve.

For example in ExoTiC-ISM you can see that the input wsdata is an array of wavelengths computed for the data - in that case the broadband white light curve.

So, while this can be an arbitrary array such as in the example, it can also be more specific for that dataset.