Update the JWST sensitivity files

Exo-TiC / ExoTiC-LD

Limb-darkening package to calculate the coefficients for specific instruments, stars, and wavelength ranges

https://exotic-ld.readthedocs.io

MIT License

8 stars 6 forks source link

Update the JWST sensitivity files #25

Closed hrwakeford closed 1 year ago

hrwakeford commented 1 year ago

Update the JWST sensitivity files in the zenodo data file with the on sky profiles.

hrwakeford commented 1 year ago

@DavoGrant please update the Zenodo links to 10.5281/zenodo.7871414 which has the new sensitivity files.

The read the docs still points to your fork of the repository so that also needs to be fixed. These can then constitute an update in the Docs and a V3.1.0 release of the package

hrwakeford commented 1 year ago

@DavoGrant I made a mistake and forgot to add back in the HST, Spitzer & Tess throughputs so will need to do that in the morning and let you know

hrwakeford commented 1 year ago

Okay @DavoGrant this one is now correct v3.1.1 It is also in the right units and format as a bonus :p

md Zenodo badge:

URL: https://doi.org/10.5281/zenodo.7874667

DavoGrant commented 1 year ago

A handful of the sensitivity files have changed name slightly and now the tests are failing. The problem files are:

JWST_NIRCam_F444_throughput.csv -- > JWST_NIRCam_F444W_throughput.csv
JWST_NIRSpec_G140H-f070_throughput.csv -- > JWST_NIRSpec_G140H-f070lp_throughput.csv
JWST_NIRSpec_G140H-f100_throughput.csv -- > JWST_NIRSpec_G140H-f100lp_throughput.csv
JWST_NIRSpec_G140M-f070_throughput.csv -- > JWST_NIRSpec_G140M-f070lp_throughput.csv
JWST_NIRSpec_G140M-f100_throughput.csv -- > JWST_NIRSpec_G140M-f100lp_throughput.csv

Can we reset the file names rather than change the code? This will avoid any issues with backwards compatibility.

hrwakeford commented 1 year ago

Done

https://zenodo.org/badge/DOI/10.5281/zenodo.7874921.svg

v3.1.2