search

Exocet-Polytechnique / ExoPIBrain

2 stars 0 forks source link

Implement classes for manometers and start button #12

Closed efondere closed 5 months ago

efondere commented 5 months ago

Le bouton n'a pas été testé, mais je préfère faire un PR avec moins de changements et passer à autre chose

closes #1

swemaster commented 5 months ago

Overall it seems like you know what you are doing, to be completely candid I have no experience in embedded python software which is why I added @EtienneLescarbeault and Zach to review this PR, but I know the coding standards. You should avoid magic numbers like 1 and 0.02 and instead have a constant file where you declare those values with a meaningful name. This also applies to strings for error messages like "Button started perfectly" or whatever.

Maybe install a python linter as well, this would ensure better code quality overtime. Make sure to specify the linter you use in the read me if anyone wants to contribute to the project